[patch, libfortran] Add prototypes for eoshift0 and eoshift2

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch, libfortran] Add prototypes for eoshift0 and eoshift2

Thomas Koenig
Committed as obvious to mainline after regtesting.

I'm not sure that this fixes PR 21594, but it surely won't hurt,
and is better practice anyway.

        Thomas

2005-06-12  Thomas Koenig  <[hidden email]>

        PR libfortran/21594
        * intrinsics/eoshift0.c:  Add prototype for eoshift0.
        * intrinsics/eoshift2.c:  Add prototype for eoshift2.


prototype-patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch, libfortran] Add prototypes for eoshift0 and eoshift2

Richard Henderson-2
On Tue, Jun 14, 2005 at 12:40:06AM +0200, Thomas Koenig wrote:
> I'm not sure that this fixes PR 21594, but it surely won't hurt,
> and is better practice anyway.

It's not necessary, doesn't fix anything, and is arguably not
better practice.



r~
Reply | Threaded
Open this post in threaded view
|

Re: [patch, libfortran] Add prototypes for eoshift0 and eoshift2

Thomas Koenig
On Mon, Jun 13, 2005 at 06:15:41PM -0700, Richard Henderson wrote:
> On Tue, Jun 14, 2005 at 12:40:06AM +0200, Thomas Koenig wrote:
> > I'm not sure that this fixes PR 21594, but it surely won't hurt,
> > and is better practice anyway.
>
> It's not necessary, doesn't fix anything, and is arguably not
> better practice.

Should I revert the patch, then?

        Thomas
Reply | Threaded
Open this post in threaded view
|

Re: [patch, libfortran] Add prototypes for eoshift0 and eoshift2

Richard Henderson-2
On Tue, Jun 14, 2005 at 10:32:35PM +0200, Thomas Koenig wrote:
> > It's not necessary, doesn't fix anything, and is arguably not
> > better practice.
>
> Should I revert the patch, then?

Please.


r~
Reply | Threaded
Open this post in threaded view
|

Re: [patch, libfortran] Add prototypes for eoshift0 and eoshift2

Thomas Koenig
On Tue, Jun 14, 2005 at 01:36:33PM -0700, Richard Henderson wrote:
> On Tue, Jun 14, 2005 at 10:32:35PM +0200, Thomas Koenig wrote:
> > > It's not necessary, doesn't fix anything, and is arguably not
> > > better practice.
> >
> > Should I revert the patch, then?
>
> Please.

OK, reverted.  ChangeLog entry:

2005-06-14  Thomas Koenig  <[hidden email]>

        * intrinsics/eoshift0.c:  Removed prototype for eoshift0.
        * intrinsics/eoshift2.c:  Removed prototype for eoshift2.

        Thomas