[patch, 10 Regression] FAIL: gfortran.dg/pr93365.f90 PR94386

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch, 10 Regression] FAIL: gfortran.dg/pr93365.f90 PR94386

Mark Eggleston
Please find attached a patch to fix test case failures of pr93365.f90,
pr93600_1.f90 and pr93600_2.f90.

OK to commit?

gcc/fortran/ChangeLog:

     Mark Eggleston  <[hidden email]>

     PR fortran/04386
     expr.c (simplify_parameter_variable):  Restore code deleted
     in PR94246.

--
https://www.codethink.co.uk/privacy.html


0001-fortran-10-Regression-FAIL-gfortran.dg-pr93365.f90-P.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch, 10 Regression] FAIL: gfortran.dg/pr93365.f90 PR94386

gcc - fortran mailing list
On Wed, Apr 01, 2020 at 02:43:46AM -0700, H.J. Lu via Gcc-patches wrote:

> On Wed, Apr 1, 2020 at 2:31 AM Mark Eggleston
> <[hidden email]> wrote:
> >
> > Please find attached a patch to fix test case failures of pr93365.f90,
> > pr93600_1.f90 and pr93600_2.f90.
> >
> > OK to commit?
> >
> > gcc/fortran/ChangeLog:
> >
> >      Mark Eggleston  <[hidden email]>
> >
> >      PR fortran/04386
>                          ^^^^^^^ Wrong PR #.
> >      expr.c (simplify_parameter_variable):  Restore code deleted

And just one space after :, not two.

> >      in PR94246.

        Jakub

Reply | Threaded
Open this post in threaded view
|

Re: [patch, 10 Regression] FAIL: gfortran.dg/pr93365.f90 PR94386

Mark Eggleston
In reply to this post by Mark Eggleston

On 01/04/2020 10:43, H.J. Lu wrote:

> On Wed, Apr 1, 2020 at 2:31 AM Mark Eggleston
> <[hidden email]> wrote:
>> Please find attached a patch to fix test case failures of pr93365.f90,
>> pr93600_1.f90 and pr93600_2.f90.
>>
>> OK to commit?
>>
>> gcc/fortran/ChangeLog:
>>
>>       Mark Eggleston  <[hidden email]>
>>
>>       PR fortran/04386
>                           ^^^^^^^ Wrong PR #.
Fixed, thanks.
>>       expr.c (simplify_parameter_variable):  Restore code deleted
>>       in PR94246.
>>
>> --
>> https://www.codethink.co.uk/privacy.html
>>
>
--
https://www.codethink.co.uk/privacy.html

Reply | Threaded
Open this post in threaded view
|

Re: [patch, 10 Regression] FAIL: gfortran.dg/pr93365.f90 PR94386

Tobias Burnus-3
In reply to this post by Mark Eggleston
LGTM with the PR/spacing fixed as noted by HJ and Jakub.

Thanks for the patch!

Tobias

On 4/1/20 11:31 AM, Mark Eggleston wrote:

> Please find attached a patch to fix test case failures of pr93365.f90,
> pr93600_1.f90 and pr93600_2.f90.
>
> OK to commit?
>
> gcc/fortran/ChangeLog:
>
>     Mark Eggleston  <[hidden email]>
>
>     PR fortran/04386
>     expr.c (simplify_parameter_variable):  Restore code deleted
>     in PR94246.
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
Reply | Threaded
Open this post in threaded view
|

Re: [patch, 10 Regression] FAIL: gfortran.dg/pr93365.f90 PR94386

Mark Eggleston
In reply to this post by gcc - fortran mailing list

On 01/04/2020 10:46, Jakub Jelinek wrote:

> On Wed, Apr 01, 2020 at 02:43:46AM -0700, H.J. Lu via Gcc-patches wrote:
>> On Wed, Apr 1, 2020 at 2:31 AM Mark Eggleston
>> <[hidden email]> wrote:
>>> Please find attached a patch to fix test case failures of pr93365.f90,
>>> pr93600_1.f90 and pr93600_2.f90.
>>>
>>> OK to commit?
>>>
>>> gcc/fortran/ChangeLog:
>>>
>>>       Mark Eggleston  <[hidden email]>
>>>
>>>       PR fortran/04386
>>                           ^^^^^^^ Wrong PR #.
>>>       expr.c (simplify_parameter_variable):  Restore code deleted
> And just one space after :, not two.
OK.
>
>>>       in PR94246.
> Jakub
>
>
--
https://www.codethink.co.uk/privacy.html