SPEC 521.wrf_r failing due to new fortran checks

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

SPEC 521.wrf_r failing due to new fortran checks

Joel Hutton
Hi Thomas,

I've noticed that SPEC has been failing to build on trunk since the below commit, do you have access to SPEC? do you know if this is due to a bug in the patch or a bug in SPEC?

>  commit ddeea2110539a432b302401a617ceb5bde191094 (HEAD, refs/bisect/bad)
>  Author: tkoenig <tkoenig@138bc75d-0d04-0410-961f-82ee72b054a4>
>  Date:   Thu Aug 15 22:52:40 2019 +0000
>     2019-08-15  Thomas Koenig  <[hidden email]>
>
>             PR fortran/91443
>             * frontend-passes.c (check_externals_expr): New function.
>             (check_externals_code): New function.
>             (gfc_check_externals): New function.
>             * gfortran.h (debug): Add prototypes for gfc_symbol * and
>             gfc_expr *.
>             (gfc_check_externals): Add prototype.
>             * interface.c (compare_actual_formal): Do not complain about
>             alternate returns if the formal argument is optional.
>             (gfc_procedure_use): Handle cases when an error has been issued
>             previously.  Break long line.
>             * parse.c (gfc_parse_file): Call gfc_check_externals for all
>             external procedures.
>             * resolve.c (resolve_global_procedure): Remove checking of
>             argument list.
>
>     2019-08-15  Thomas Koenig  <[hidden email]>
>
>             PR fortran/91443
>             * gfortran.dg/argument_checking_19.f90: New test.
>             * gfortran.dg/altreturn_10.f90: Change dg-warning to dg-error.
>             * gfortran.dg/dec_union_11.f90: Add -std=legacy.
>             * gfortran.dg/hollerith8.f90: Likewise. Remove warning for
>             Hollerith constant.
>             * gfortran.dg/integer_exponentiation_2.f90: New subroutine gee_i8;
>             use it to avoid type mismatches.
>             * gfortran.dg/pr41011.f: Add -std=legacy.
>             * gfortran.dg/whole_file_1.f90: Change warnings to errors.
>             * gfortran.dg/whole_file_2.f90: Likewise.
>
>     git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@274551 138bc75d-0d04-0410-961f-82ee72b054a4

Joel

Reply | Threaded
Open this post in threaded view
|

Re: SPEC 521.wrf_r failing due to new fortran checks

Thomas König
Hi Joel,

> I've noticed that SPEC has been failing to build on trunk since the
> below commit, do you have access to SPEC?

None of the gfortran maintainers has access to SPEC.

> do you know if this is due to
> a bug in the patch or a bug in SPEC?

The SPEC suite has quite a few bugs, which SPEC refuses to fix.
This is one of them.  This is one of the reasons why I have a rather
low opinion of SPEC. The other one is that, as somebody who donates
his time, I do draw the line at purchasing commercial software
for several thousands of euros (or dollars).

There is a workaround, see the updated gfortran documentation or
https://gcc.gnu.org/gcc-10/changes.html .

Regards

        Thomas