Re: [v3 PATCH] PR libstdc++/87855

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Re: [v3 PATCH] PR libstdc++/87855

Jonathan Wakely-3
On 15/11/18 14:00 +0200, Ville Voutilainen wrote:
>Tested on Linux-PPC64. Ok for trunk? Backports?

One problem ...

>--- /dev/null
>+++ b/libstdc++-v3/testsuite/20_util/optional/assignment/
>@@ -0,0 +1,98 @@
>+// { dg-options "-std=gnu++17" }
>+// { dg-do compile }

This needs to be:

// { dg-do compile { target c++17 } }

Otherwise it FAILs with DejaGnu 1.5.2 and older when using something
like --target_board=unix/-std=c++14 (because old versions of DejaGnu
override the explicit dg-options in the testcase with the
--target_board options).

If you use { target c++17 } then when the old DejaGnu overrides your
{ dg-options "-std=gnu++17" } setting it still correctly skips the
test for older dialects, instead of getting a FAIL.

OK for trunk with that change, thanks.

I think it's OK to backport, but maybe let's wait a few weeks. Keep
the bugzilla open for now, until you do that backport.