Re: [patch, fortran] Fix PR 78865, ICE on invalid

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [patch, fortran] Fix PR 78865, ICE on invalid

Paul Richard Thomas
Hi Thomas,

This is OK for trunk and, after a wee delay for the other active branches.

Thanks

Paul

On Fri, 22 Mar 2019 at 22:56, Thomas Koenig <[hidden email]> wrote:

>
> Hello world,
>
> the attached patch fixes a 7/8/9 regression.  The problem was twofold:
> If a subroutine was called more than once from a different subroutine,
> the call was only checked the first time.  Also, a type change in the
> backend_decl initiated when there was already a declaration led to an
> ICE.
>
> The solution also has two parts: Make sure that a hard error is
> delivered in this case, and make sure the check is done every time.
>
> Regression-tested. OK for trunk and other affected branches?
>
> Regards
>
>         Thomas
>
> 2019-03-22  Thomas Koenig  <[hidden email]>
>
>         PR fortran/78865
>         * interface.c (compare_actual_formal): Change errors about
>         missing or extra to gfc_error_now to make sure they are issued.
>         Change "spec" to "specifier" in message.
>         * resolve.c (resolve_global_procedure): Also check for mismatching
>         interface with global symbols if the namespace has already been
>         resolved.
>
> 2019-03-22  Thomas Koenig  <[hidden email]>
>
>         PR fortran/78865
>         * gfortran.dg/altreturn_10.f90: New test.
>         * gfortran.dg/whole_file_3.f90: Change dg-warning to dg-error.



--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein