Re: [Patch, Fortran] PR87597 - fix off-by-one issue with inline matmul

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Patch, Fortran] PR87597 - fix off-by-one issue with inline matmul

Tobias Burnus
Hi Dominique,

Dominique d'Humières wrote:
> UNRESOLVED: gfortran.dg/inline_matmul_24.f90   -O0   scan-tree-dump-times optimized "gamma5[__var_1_do \\\\* 4 \\\\+ __var_2_do]" 1
>
> ! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+ __var_2_do\]" 1 "optimized" } }
>
> Shouldn’t -fdump-tree-original be -fdump-tree-optimized?

As it is a front-end optimization (which is explicitly enabled),
-fdump-tree-original should work (and avoids issues with further later
optimizations).

What do you get on your system? Seemingly something else than I do. Can
you look for the gamma5 line in your dump?

Tobias

Reply | Threaded
Open this post in threaded view
|

Re: [Patch, Fortran] PR87597 - fix off-by-one issue with inline matmul

Dominique d'Humières-2


> Le 14 oct. 2018 à 00:43, Tobias Burnus <[hidden email]> a écrit :
>
> Hi Dominique,
>
> Dominique d'Humières wrote:
>> UNRESOLVED: gfortran.dg/inline_matmul_24.f90   -O0   scan-tree-dump-times optimized "gamma5[__var_1_do \\\\* 4 \\\\+ __var_2_do]" 1
>>
>> ! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+ __var_2_do\]" 1 "optimized" } }
>>
>> Shouldn’t -fdump-tree-original be -fdump-tree-optimized?
>
> As it is a front-end optimization (which is explicitly enabled), -fdump-tree-original should work (and avoids issues with further later optimizations).
>
> What do you get on your system? Seemingly something else than I do. Can you look for the gamma5 line in your dump?
>
> Tobias

Then

! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+ __var_2_do\]" 1 "optimized" } }

should be

! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+ __var_2_do\]" 1 "original" } }

isn’t it?

see https://gcc.gnu.org/ml/gcc-testresults/2018-10/msg01721.html for non darwin log.

Dominique

Reply | Threaded
Open this post in threaded view
|

Re: [Patch, Fortran] PR87597 - fix off-by-one issue with inline matmul

Tobias Burnus
Right commit revision, wrong attached file (original patch, not the
follow-up one).
Now hopefully the correct one.

Tobias

Am 15.10.18 um 21:02 schrieb Tobias Burnus:

> Fixed with commit Rev. 265175 as attached.
>
> Cheers
>
> Tobias
>
>
> Dominique d'Humières wrote:
>
>>> Le 14 oct. 2018 à 00:43, Tobias Burnus <[hidden email]> a écrit :
>>>
>>>
>>> Dominique d'Humières wrote:
>>>> UNRESOLVED: gfortran.dg/inline_matmul_24.f90   -O0
>>>> scan-tree-dump-times optimized "gamma5[__var_1_do \\\\* 4 \\\\+
>>>> __var_2_do]" 1
>>>>
>>>> ! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+
>>>> __var_2_do\]" 1 "optimized" } }
>>>>
>>>> Shouldn’t -fdump-tree-original be -fdump-tree-optimized?
>>> As it is a front-end optimization (which is explicitly enabled),
>>> -fdump-tree-original should work (and avoids issues with further
>>> later optimizations).
>>>
>>> What do you get on your system? Seemingly something else than I do.
>>> Can you look for the gamma5 line in your dump?
>>>
>>> Tobias
>> Then
>>
>> ! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+
>> __var_2_do\]" 1 "optimized" } }
>>
>> should be
>>
>> ! { dg-final { scan-tree-dump-times "gamma5\[__var_1_do \\* 4 \\+
>> __var_2_do\]" 1 "original" } }
>>
>> isn’t it?
>>
>> see https://gcc.gnu.org/ml/gcc-testresults/2018-10/msg01721.html for
>> non darwin log.
>>
>> Dominique

pr87597.diff (1K) Download Attachment