Re: [Patch][Fortran] OpenMP – libgomp/testsuite – use 'stop' and 'dg-do run'

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Patch][Fortran] OpenMP – libgomp/testsuite – use 'stop' and 'dg-do run'

Tobias Burnus-5
Hi,

thanks for the review.

On 10/30/19 10:31 AM, Jakub Jelinek wrote:
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_orphan.f
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_reduction.f
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_workshare1.f
>> --- a/libgomp/testsuite/libgomp.fortran/omp_workshare2.f
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_workshare2.f
> Dunno, maybe, though not clear advantages of doing so.

I didn't added 'dg-do run' for those.
Otherwise as suggested – and committed as Rev. 277606.

> I'm not really happy about the uppercase STOP in all the
> libgomp.fortran tests that are written completely in lowercase except
> these stops, but didn't get around to changing it yet.

How about the following patch? Created by
sed -i -e 's/STOP /stop /' in testsuite/libgomp.fortran/
and glanced over. (Seemingly, no all-capital-letters file exists.)

?

Tobias


STOP-stop.diff (199K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch][Fortran] OpenMP – libgomp/testsuite – use 'stop' and 'dg-do run'

Jakub Jelinek
On Wed, Oct 30, 2019 at 11:45:11AM +0100, Tobias Burnus wrote:

> On 10/30/19 10:31 AM, Jakub Jelinek wrote:
> > > +++ b/libgomp/testsuite/libgomp.fortran/omp_orphan.f
> > > +++ b/libgomp/testsuite/libgomp.fortran/omp_reduction.f
> > > +++ b/libgomp/testsuite/libgomp.fortran/omp_workshare1.f
> > > --- a/libgomp/testsuite/libgomp.fortran/omp_workshare2.f
> > > +++ b/libgomp/testsuite/libgomp.fortran/omp_workshare2.f
> > Dunno, maybe, though not clear advantages of doing so.
>
> I didn't added 'dg-do run' for those.
> Otherwise as suggested – and committed as Rev. 277606.

Thanks.

> > I'm not really happy about the uppercase STOP in all the libgomp.fortran
> > tests that are written completely in lowercase except these stops, but
> > didn't get around to changing it yet.
>
> How about the following patch? Created by
> sed -i -e 's/STOP /stop /' in testsuite/libgomp.fortran/
> and glanced over. (Seemingly, no all-capital-letters file exists.)

> --- a/libgomp/testsuite/libgomp.fortran/lib2.f
> +++ b/libgomp/testsuite/libgomp.fortran/lib2.f
> @@ -14 +14 @@ C { dg-do run }
> -      IF (OMP_TEST_LOCK (LCK)) STOP 1
> +      IF (OMP_TEST_LOCK (LCK)) stop 1
...
> --- a/libgomp/testsuite/libgomp.fortran/lib3.f
> +++ b/libgomp/testsuite/libgomp.fortran/lib3.f
> --- a/libgomp/testsuite/libgomp.fortran/pr25162.f
> +++ b/libgomp/testsuite/libgomp.fortran/pr25162.f

Please don't change these 3 tests, they are all-capital-letters, at least on
the corresponding lines, comments and especially dg-* directives which have
to be lowercase don't count (I've looked for IF in capital letters
in your patch ;) ).

Otherwise LGTM, thanks.

        Jakub