Re: [PATCH] libgfortran: Use __builtin_mul_overflow in xmallocarray

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] libgfortran: Use __builtin_mul_overflow in xmallocarray

Steve Kargl
On Fri, Jun 14, 2019 at 01:08:48PM +0300, Janne Blomqvist wrote:
> As GCC now provides builtins for doing integer overflow checking, lets
> use it when checking for overflow in xmallocarray.
>
> Regtested on x86_64-pc-linux-gnu, Ok for trunk?
>

OK

--
Steve
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] libgfortran: Use __builtin_mul_overflow in xmallocarray

Steve Kargl
On Fri, Jun 14, 2019 at 08:07:36AM -0700, Steve Kargl wrote:
> On Fri, Jun 14, 2019 at 01:08:48PM +0300, Janne Blomqvist wrote:
> > As GCC now provides builtins for doing integer overflow checking, lets
> > use it when checking for overflow in xmallocarray.
> >
> > Regtested on x86_64-pc-linux-gnu, Ok for trunk?
> >
>
> OK
>

Just found

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65921

I assume that you close the PR.

--
Steve
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] libgfortran: Use __builtin_mul_overflow in xmallocarray

Janne Blomqvist-3
On Sat, Jun 15, 2019 at 2:23 AM Steve Kargl
<[hidden email]> wrote:

>
> On Fri, Jun 14, 2019 at 08:07:36AM -0700, Steve Kargl wrote:
> > On Fri, Jun 14, 2019 at 01:08:48PM +0300, Janne Blomqvist wrote:
> > > As GCC now provides builtins for doing integer overflow checking, lets
> > > use it when checking for overflow in xmallocarray.
> > >
> > > Regtested on x86_64-pc-linux-gnu, Ok for trunk?
> > >
> >
> > OK
> >
>
> Just found
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65921
>
> I assume that you close the PR.

Oh, I had completely forgotten that I filed that one!

(I won't close it yet as the frontend part is still to be done)


--
Janne Blomqvist