Re: [PATCH,Fortran] Taking a BYTE out of type-spec

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH,Fortran] Taking a BYTE out of type-spec

Tobias Burnus-5
On 10/24/19 10:43 PM, Steve Kargl wrote:
> The patch moves the matching of the nonstandard type-spec
> BYTE to its own matching function.  During this move, a
> check for invalid matching in free-form source code it
> detected (see byte_4.f90).  OK to commit?

OK with a nit.

> +      if (gfc_current_form == FORM_FREE)
> + {
> +  char c = gfc_peek_ascii_char ();
> +  if (!gfc_is_whitespace (c) && c != ',')
> +    return MATCH_NO;

You also want to permit "byte::var", hence: c == ':' is also okay – you
can also add this as variant to the test case.

Cheers,

Tobias