Re: [PATCH] Fix the fix for PR fortran/90988

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix the fix for PR fortran/90988

Jeff Law
On 11/1/19 1:49 AM, Tobias Burnus wrote:
> On 10/31/19 11:16 PM, Steve Kargl wrote:
>
>> Jeff Law sent me an email … caused a regression for fixed-form
>> source code.
>
> Interesting, what kind of code is used in the real world!
It's from the dl_poly package in Fedora IIRC.  It was the only instance
of this problem across the Fedora builds.
jeff

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix the fix for PR fortran/90988

Steve Kargl
On Fri, Nov 01, 2019 at 08:49:58AM +0100, Tobias Burnus wrote:
> On 10/31/19 11:16 PM, Steve Kargl wrote:
>
> > Jeff Law sent me an email … caused a regression for fixed-form
> > source code.
>
> Interesting, what kind of code is used in the real world!
>

Jeff sent me the file from dl_poly that ran into thre regression.
The dl_ploy developers use modern Fortran, but at least one file
restrict themselves to fixed-form source code.  This seems to be
an odd choice to me, but it is legal Fortran.

> > OK to commit?
>
> OK. Thanks for the patch!
>

Thanks.  And, sorry about the regression.

--
Steve