[PATCH testsuite, arm] cache fp16 hw effective-target tests

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH testsuite, arm] cache fp16 hw effective-target tests

Sandra Loosemore
In some bare-metal environments, the tests for fp16 runtime support fail
in a way that causes a timeout rather than immediate failure.  (E.g.,
the runtime might provide a do-nothing exception handler that just sits
in a tight loop and never returns.)  This patch changes the
effective-target tests for fp16 hardware support to cache the result of
the test so that we don't have to do this more than once.  I think it
was probably just an oversight that it wasn't done this way originally,
since the target is hardly likely to sprout fp16 instruction support
midway through the test run anyway.  ;-)  Anyway, test results are the
same with this patch, they just run faster.  OK to commit?

-Sandra

fp16-hw.log (242 bytes) Download Attachment
fp16-hw.patch (718 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH testsuite, arm] cache fp16 hw effective-target tests

Ramana Radhakrishnan [on liliput]
On Fri, Sep 13, 2019 at 5:31 PM Sandra Loosemore
<[hidden email]> wrote:

>
> In some bare-metal environments, the tests for fp16 runtime support fail
> in a way that causes a timeout rather than immediate failure.  (E.g.,
> the runtime might provide a do-nothing exception handler that just sits
> in a tight loop and never returns.)  This patch changes the
> effective-target tests for fp16 hardware support to cache the result of
> the test so that we don't have to do this more than once.  I think it
> was probably just an oversight that it wasn't done this way originally,
> since the target is hardly likely to sprout fp16 instruction support
> midway through the test run anyway.  ;-)  Anyway, test results are the
> same with this patch, they just run faster.  OK to commit?

Ok, thanks.

Ramana

>
> -Sandra