[PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls

Mihail Ionescu
Hi All,

This is a backport from trunk for GCC 8 and 7.

SVN revision: r264595.

Regression tested on arm-none-eabi.


gcc/ChangeLog

2018-11-02  Mihail Ionescu  <[hidden email]>

        Backport from mainiline
        2018-09-26  Eric Botcazou  <[hidden email]>

        * config/arm/arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
        (arm32_output_mi_thunk): Deal with long calls.

gcc/testsuite/ChangeLog

2018-11-02  Mihail Ionescu  <[hidden email]>

        Backport from mainiline
         2018-09-17  Eric Botcazou  <[hidden email]>

        * g++.dg/other/thunk2a.C: New test.
        * g++.dg/other/thunk2b.C: Likewise.


If everything is ok, could someone commit it on my behalf?

Best regards,
    Mihail
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls

Ramana Radhakrishnan-4
On 07/11/2018 17:49, Mihail Ionescu wrote:

> Hi All,
>
> This is a backport from trunk for GCC 8 and 7.
>
> SVN revision: r264595.
>
> Regression tested on arm-none-eabi.
>
>
> gcc/ChangeLog
>
> 2018-11-02  Mihail Ionescu  <[hidden email]>
>
> Backport from mainiline
> 2018-09-26  Eric Botcazou  <[hidden email]>
>
> * config/arm/arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
> (arm32_output_mi_thunk): Deal with long calls.
>
> gcc/testsuite/ChangeLog
>
> 2018-11-02  Mihail Ionescu  <[hidden email]>
>
> Backport from mainiline
>           2018-09-17  Eric Botcazou  <[hidden email]>
>
> * g++.dg/other/thunk2a.C: New test.
> * g++.dg/other/thunk2b.C: Likewise.
>
>
> If everything is ok, could someone commit it on my behalf?
>
> Best regards,
>      Mihail
>

It is a regression since my rewrite of this code.

Ok to backport to the release branches, it's been on trunk for a while
and not shown any issues - please give the release managers a day or so
to object.

regards
Ramana
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls

Sudakshina Das-2
Hi Mihail

On 08/11/18 10:02, Ramana Radhakrishnan wrote:

> On 07/11/2018 17:49, Mihail Ionescu wrote:
>> Hi All,
>>
>> This is a backport from trunk for GCC 8 and 7.
>>
>> SVN revision: r264595.
>>
>> Regression tested on arm-none-eabi.
>>
>>
>> gcc/ChangeLog
>>
>> 2018-11-02  Mihail Ionescu  <[hidden email]>
>>
>> Backport from mainiline
>> 2018-09-26  Eric Botcazou  <[hidden email]>
>>
>> * config/arm/arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
>> (arm32_output_mi_thunk): Deal with long calls.
>>
>> gcc/testsuite/ChangeLog
>>
>> 2018-11-02  Mihail Ionescu  <[hidden email]>
>>
>> Backport from mainiline
>>            2018-09-17  Eric Botcazou  <[hidden email]>
>>
>> * g++.dg/other/thunk2a.C: New test.
>> * g++.dg/other/thunk2b.C: Likewise.
>>
>>
>> If everything is ok, could someone commit it on my behalf?
>>
>> Best regards,
>>       Mihail
>>
>
> It is a regression since my rewrite of this code.
>
> Ok to backport to the release branches, it's been on trunk for a while
> and not shown any issues - please give the release managers a day or so
> to object.
>
> regards
> Ramana
>

Does this fix PR87867 you reported? If yes, then it would be easier
to add the PR tag in the ChangeLog so that the ticket gets updated once
committed.

Thanks
Sudi
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls

Mihail Ionescu
Hi Sudi

On 11/08/2018 06:53 PM, Sudakshina Das wrote:

> Hi Mihail
>
> On 08/11/18 10:02, Ramana Radhakrishnan wrote:
>> On 07/11/2018 17:49, Mihail Ionescu wrote:
>>> Hi All,
>>>
>>> This is a backport from trunk for GCC 8 and 7.
>>>
>>> SVN revision: r264595.
>>>
>>> Regression tested on arm-none-eabi.
>>>
>>>
>>> gcc/ChangeLog
>>>
>>> 2018-11-02  Mihail Ionescu  <[hidden email]>
>>>
>>> Backport from mainiline
>>> 2018-09-26  Eric Botcazou  <[hidden email]>
>>>
>>> * config/arm/arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
>>> (arm32_output_mi_thunk): Deal with long calls.
>>>
>>> gcc/testsuite/ChangeLog
>>>
>>> 2018-11-02  Mihail Ionescu  <[hidden email]>
>>>
>>> Backport from mainiline
>>>             2018-09-17  Eric Botcazou  <[hidden email]>
>>>
>>> * g++.dg/other/thunk2a.C: New test.
>>> * g++.dg/other/thunk2b.C: Likewise.
>>>
>>>
>>> If everything is ok, could someone commit it on my behalf?
>>>
>>> Best regards,
>>>        Mihail
>>>
>>
>> It is a regression since my rewrite of this code.
>>
>> Ok to backport to the release branches, it's been on trunk for a while
>> and not shown any issues - please give the release managers a day or so
>> to object.
>>
>> regards
>> Ramana
>>
>
> Does this fix PR87867 you reported? If yes, then it would be easier
> to add the PR tag in the ChangeLog so that the ticket gets updated once
> committed.
>
> Thanks
> Sudi
>

I've seen the patch has been commited (Ramana added the PR tag), but I
now know it has to be added and I will do it in the future.

Regards
Mihail