[PATCH][PR91749][arm] FDPIC: Handle -mflip-thumb

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][PR91749][arm] FDPIC: Handle -mflip-thumb

Christophe Lyon-2
[Re-sending in plain text-mode, sorry for the duplicates]

Hi,

In PR91749, we have ICEs because -mflip-thumb switches to Thumb-1 (the
default target cpu does not support Thumb-2).

Although we already filter this in arm_configure_build_target, we
forgot to handle cases when the mode is changed via attributes (either
in the source code, or via -mflip-thumb).

This patch adds the same error message when trying to apply the
"thumb" attribute and the target does not support Thumb-2 (only if we
are in FDPIC mode, of course).

OK?

Thanks,

Christophe

fdpic-flip-thumb.chlog.txt (278 bytes) Download Attachment
fdpic-flip-thumb.patch.txt (778 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH][PR91749][arm] FDPIC: Handle -mflip-thumb

Ramana Radhakrishnan [on liliput]
On Mon, Sep 16, 2019 at 2:40 PM Christophe Lyon
<[hidden email]> wrote:

>
> [Re-sending in plain text-mode, sorry for the duplicates]
>
> Hi,
>
> In PR91749, we have ICEs because -mflip-thumb switches to Thumb-1 (the
> default target cpu does not support Thumb-2).
>
> Although we already filter this in arm_configure_build_target, we
> forgot to handle cases when the mode is changed via attributes (either
> in the source code, or via -mflip-thumb).
>
> This patch adds the same error message when trying to apply the
> "thumb" attribute and the target does not support Thumb-2 (only if we
> are in FDPIC mode, of course).
>
> OK?

OK.

Ramana
>
> Thanks,
>
> Christophe