[PATCH] Fix the fix for PR fortran/90988

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix the fix for PR fortran/90988

Steve Kargl
Jeff Law sent me an email that showed my patch for
PR fortran/90988 caused a regression for fixed-form
source code.  The attached patch address that regression.

Briefly, the original patch fixed free-form souce code
parsing for 'PUBLICX' where the required whitespace was
missing (i.e., 'PUBLIC X').  Unfortunately, the regression
is that the original fix did not preserve fixed-form source
code.

OK to commit?

2019-10-31  Steven G. Kargl  <[hidden email]>

        PR fortran/90988
        * decl.c (gfc_match_private, gfc_match_public): Fixed-form source code
        does not require whitespace between PRIVATE (or PUBLIC) and an entity.

2019-10-31  Steven G. Kargl  <[hidden email]>

        PR fortran/90988
        * gfortran.dg/pr90988_4.f: New test.

--
Steve

pr90988.diff (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix the fix for PR fortran/90988

Tobias Burnus-3
On 10/31/19 11:16 PM, Steve Kargl wrote:

> Jeff Law sent me an email … caused a regression for fixed-form
> source code.

Interesting, what kind of code is used in the real world!

> OK to commit?

OK. Thanks for the patch!

Tobias

> 2019-10-31  Steven G. Kargl  <[hidden email]>
>
> PR fortran/90988
> * decl.c (gfc_match_private, gfc_match_public): Fixed-form source code
> does not require whitespace between PRIVATE (or PUBLIC) and an entity.
>
> 2019-10-31  Steven G. Kargl  <[hidden email]>
>
> PR fortran/90988
> * gfortran.dg/pr90988_4.f: New test.