[PATCH] Fix PR92554

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix PR92554

Richard Biener

The followng fixes yet another case where conversions confuse epilogue
generation, this times for condition vectorization.

Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.

Richard.

2019-11-19  Richard Biener  <[hidden email]>

        PR tree-optimization/92554
        * tree-vect-loop.c (vect_create_epilog_for_reduction): Look
        for the actual condition stmt and deal with sign-changes.

        * gcc.dg/vect/pr92554.c: New testcase.

Index: gcc/tree-vect-loop.c
===================================================================
--- gcc/tree-vect-loop.c (revision 278406)
+++ gcc/tree-vect-loop.c (working copy)
@@ -4540,12 +4552,21 @@ vect_create_epilog_for_reduction (stmt_v
      zeroes.  */
   if (STMT_VINFO_REDUC_TYPE (reduc_info) == COND_REDUCTION)
     {
-      tree indx_before_incr, indx_after_incr;
-      poly_uint64 nunits_out = TYPE_VECTOR_SUBPARTS (vectype);
-
-      gimple *vec_stmt = STMT_VINFO_VEC_STMT (stmt_info)->stmt;
+      stmt_vec_info cond_info = STMT_VINFO_REDUC_DEF (reduc_info);
+      cond_info = vect_stmt_to_vectorize (cond_info);
+      while (gimple_assign_rhs_code (cond_info->stmt) != COND_EXPR)
+ {
+  cond_info
+    = loop_vinfo->lookup_def (gimple_op (cond_info->stmt,
+ 1 + STMT_VINFO_REDUC_IDX
+ (cond_info)));
+  cond_info = vect_stmt_to_vectorize (cond_info);
+ }
+      gimple *vec_stmt = STMT_VINFO_VEC_STMT (cond_info)->stmt;
       gcc_assert (gimple_assign_rhs_code (vec_stmt) == VEC_COND_EXPR);
 
+      tree indx_before_incr, indx_after_incr;
+      poly_uint64 nunits_out = TYPE_VECTOR_SUBPARTS (vectype);
       int scalar_precision
  = GET_MODE_PRECISION (SCALAR_TYPE_MODE (TREE_TYPE (vectype)));
       tree cr_index_scalar_type = make_unsigned_type (scalar_precision);
@@ -4599,9 +4620,9 @@ vect_create_epilog_for_reduction (stmt_v
  (CCOMPARE).  The then and else values mirror the main VEC_COND_EXPR:
  the reduction phi corresponds to NEW_PHI_TREE and the new values
  correspond to INDEX_BEFORE_INCR.  */
-      gcc_assert (STMT_VINFO_REDUC_IDX (stmt_info) >= 1);
+      gcc_assert (STMT_VINFO_REDUC_IDX (cond_info) >= 1);
       tree index_cond_expr;
-      if (STMT_VINFO_REDUC_IDX (stmt_info) == 2)
+      if (STMT_VINFO_REDUC_IDX (cond_info) == 2)
  index_cond_expr = build3 (VEC_COND_EXPR, cr_index_vector_type,
   ccompare, indx_before_incr, new_phi_tree);
       else
@@ -4797,10 +4818,11 @@ vect_create_epilog_for_reduction (stmt_v
  be zero.  */
 
       /* Vector of {0, 0, 0,...}.  */
-      tree zero_vec = make_ssa_name (vectype);
-      tree zero_vec_rhs = build_zero_cst (vectype);
-      gimple *zero_vec_stmt = gimple_build_assign (zero_vec, zero_vec_rhs);
-      gsi_insert_before (&exit_gsi, zero_vec_stmt, GSI_SAME_STMT);
+      tree zero_vec = build_zero_cst (vectype);
+
+      gimple_seq stmts = NULL;
+      new_phi_result = gimple_convert (&stmts, vectype, new_phi_result);
+      gsi_insert_seq_before (&exit_gsi, stmts, GSI_SAME_STMT);
 
       /* Find maximum value from the vector of found indexes.  */
       tree max_index = make_ssa_name (index_scalar_type);
@@ -4868,7 +4890,7 @@ vect_create_epilog_for_reduction (stmt_v
 
       /* Convert the reduced value back to the result type and set as the
  result.  */
-      gimple_seq stmts = NULL;
+      stmts = NULL;
       new_temp = gimple_build (&stmts, VIEW_CONVERT_EXPR, scalar_type,
        data_reduc);
       gsi_insert_seq_before (&exit_gsi, stmts, GSI_SAME_STMT);
Index: gcc/testsuite/gcc.dg/vect/pr92554.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr92554.c (nonexistent)
+++ gcc/testsuite/gcc.dg/vect/pr92554.c (working copy)
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+
+short int w9;
+
+void __attribute__ ((simd))
+zc (int in)
+{
+  int va = 1;
+
+  w9 *= va != 0 ? in < 0 : 0;
+}