[PATCH][DOC] Document -fallocation-dce.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH][DOC] Document -fallocation-dce.

Martin Liška-2
Hi.

The patch is about a documentation entry for a newly added
option in GCC 10.

Ready for trunk?
Martin

gcc/ChangeLog:

2019-11-13  Martin Liska  <[hidden email]>

        PR other/92329
        * doc/invoke.texi: Document -fallocation-dce.
---
  gcc/doc/invoke.texi | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)



0001-Document-fallocation-dce.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH][DOC] Document -fallocation-dce.

Sandra Loosemore
On 11/13/19 6:45 AM, Martin Liška wrote:
> Hi.
>
> The patch is about a documentation entry for a newly added
> option in GCC 10.
>
> Ready for trunk?

I thought this would be OK, until I saw:

> +Enabled by default.

At the beginning of invoke.texi where it is talking about options having
both -foo and -fno-foo forms, it says "This manual documents
only one of these two forms, whichever one is not the default."  So I
think you should be documenting -fno-allocation-dce here instead of the
positive form.

-Sandra
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH][DOC] Document -fallocation-dce.

Martin Liška-2
On 11/13/19 4:25 PM, Sandra Loosemore wrote:

> On 11/13/19 6:45 AM, Martin Liška wrote:
>> Hi.
>>
>> The patch is about a documentation entry for a newly added
>> option in GCC 10.
>>
>> Ready for trunk?
>
> I thought this would be OK, until I saw:
>
>> +Enabled by default.
>
> At the beginning of invoke.texi where it is talking about options having both -foo and -fno-foo forms, it says "This manual documents
> only one of these two forms, whichever one is not the default."  So I think you should be documenting -fno-allocation-dce here instead of the positive form.
Thank you for the review.
I've changed that and I'm going to install the patch.

Martin

>
> -Sandra


0001-Document-fallocation-dce.patch (1K) Download Attachment