Old options in self tests?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Old options in self tests?

Anthony Green

My builds from HEAD are failing unless I remove these tests.  Are these
invalid tests?

diff --git a/gcc/opt-suggestions.c b/gcc/opt-suggestions.c
index 9444a35cb54..e64ee7e5660 100644
--- a/gcc/opt-suggestions.c
+++ b/gcc/opt-suggestions.c
@@ -264,8 +264,6 @@ test_completion_valid_options (option_proposer &proposer)
     "-Wno-format-contains-nul",
     "-Wnamespaces",
     "-fisolate-erroneous-paths-attribute",
-    "-Wno-underflow",
-    "-Wtarget-lifetime",
     "--param=asan-globals",
     "-Wno-empty-body",
     "-Wno-odr",
@@ -273,7 +271,6 @@ test_completion_valid_options (option_proposer &proposer)
     "-Wstringop-truncation",
     "-fno-ipa-vrp",
     "-fmath-errno",
-    "-Warray-temporaries",
     "-Wno-unused-label",
     "-Wreturn-local-addr",
     "--param=sms-dfa-history",

AG
Reply | Threaded
Open this post in threaded view
|

Re: Old options in self tests?

Jeff Law
On 10/4/18 6:05 AM, Anthony Green wrote:

>
> My builds from HEAD are failing unless I remove these tests.  Are these
> invalid tests?
>
> diff --git a/gcc/opt-suggestions.c b/gcc/opt-suggestions.c
> index 9444a35cb54..e64ee7e5660 100644
> --- a/gcc/opt-suggestions.c
> +++ b/gcc/opt-suggestions.c
> @@ -264,8 +264,6 @@ test_completion_valid_options (option_proposer &proposer)
>      "-Wno-format-contains-nul",
>      "-Wnamespaces",
>      "-fisolate-erroneous-paths-attribute",
> -    "-Wno-underflow",
> -    "-Wtarget-lifetime",
>      "--param=asan-globals",
>      "-Wno-empty-body",
>      "-Wno-odr",
> @@ -273,7 +271,6 @@ test_completion_valid_options (option_proposer &proposer)
>      "-Wstringop-truncation",
>      "-fno-ipa-vrp",
>      "-fmath-errno",
> -    "-Warray-temporaries",
>      "-Wno-unused-label",
>      "-Wreturn-local-addr",
>      "--param=sms-dfa-history",
>
> AG
>
They're Fortran specific options.  I'm not sure how that impacts your
tests though.

jeff
Reply | Threaded
Open this post in threaded view
|

Re: Old options in self tests?

Anthony Green
Jeff Law <[hidden email]> writes:

> They're Fortran specific options.  I'm not sure how that impacts your
> tests though.

Thanks Jeff.  I figured this out now.  I was building a C compiler from
a source tree that does not include the sources for the fortran
front-end.  It seems that this is no longer supported, and the fortran
sources must be available even if you're only building C/C++.

I'll stop stripping out gcc/fortran, but I'm wondering if anybody else
considers this a misfeature.

AG
Reply | Threaded
Open this post in threaded view
|

Re: Old options in self tests?

Gerald Pfeifer
On Thu, 4 Oct 2018, Anthony Green wrote:
> I was building a C compiler from a source tree that does not include
> the sources for the fortran front-end.  It seems that this is no longer
> supported, and the fortran sources must be available even if you're only
> building C/C++.
>
> I'll stop stripping out gcc/fortran, but I'm wondering if anybody else
> considers this a misfeature.

It looks like a mistfeature to me (even if not as bad as it would
have been in the past when we provided more finely grained tarballs
for snapshots and releases).

Gerald