[C++ Patch] Fixes for three grokbitfield diagnostics

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[C++ Patch] Fixes for three grokbitfield diagnostics

Paolo Carlini-3
Hi,

these should be more or less straightforward (now that
DECL_SOURCE_LOCATION often extracts a proper location ;). In the case of
warn_if_not_aligned I also removed the redundant width check (it's never
null, double checked by running the instrumented testsuite too) and I
also removed the DECL_NAME use, which definitely doesn't play well with
unnamed declarations (other/bitfield7.C exercises that too).

Tested x86_64-linux, as usual.

Thanks, Paolo.

//////////////////////


CL_grokbitfield3 (670 bytes) Download Attachment
patch_grokbitfield3 (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [C++ Patch] Fixes for three grokbitfield diagnostics

Jason Merrill
On 12/7/18 5:39 AM, Paolo Carlini wrote:

> Hi,
>
> these should be more or less straightforward (now that
> DECL_SOURCE_LOCATION often extracts a proper location ;). In the case of
> warn_if_not_aligned I also removed the redundant width check (it's never
> null, double checked by running the instrumented testsuite too) and I
> also removed the DECL_NAME use, which definitely doesn't play well with
> unnamed declarations (other/bitfield7.C exercises that too).
>
> Tested x86_64-linux, as usual.
>
> Thanks, Paolo.
>
> //////////////////////
>
OK.

Jason